Ensure value_cast<QP> uses the minimum number of operataions needed
#598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m another QP to leverage sudo_cast
|
@burnpanck, I fixed all the CI issues today. If you could rebase to master, we would see this change's real CI status. |
|
@burnpanck, do you still plan to work on your PRs? |
|
Hi @burnpanck! Do you plan to work on those in the near future. I plan to release mp-units 2.3 soon. |
burnpanck
force-pushed
the
feature/efficient-value-cast-QP
branch
from
341b4eb to
61198fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supposed to continue from the discussion here, where
value_cast<QP>was introduced.Basically,
value_cast<QP>does three steps:However, in the current implementation, the second step (change of origin) may in fact introduce more representation conversions internally: to a common representation between the offset and the value. However, here, that is not necessary, because the representation of the value is already chosen suitably.