[Stats results mapper] - Include viability category field on final stats_results_parquet#538
Open
francisco-ebi wants to merge 3 commits into
Open
[Stats results mapper] - Include viability category field on final stats_results_parquet#538francisco-ebi wants to merge 3 commits into
francisco-ebi wants to merge 3 commits into
Conversation
7f0a23a to
405a219
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in the function that generates the viability_stats dataframe (viability_stats_results) is already picking the correct field(the viability statement) based on the VIA parameter version. So it would only be a matter of propagating the field through the intermediate parquets.
So I updated 2 stages of the statistical results mapper to make the "category" field available on the final statistical_results parquet:
Let me know if I have missed anything.