Skip to content

Fixes for code check #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wgropp opened this issue Mar 29, 2025 · 0 comments
Open

Fixes for code check #988

wgropp opened this issue Mar 29, 2025 · 0 comments
Labels
editor change Changes to be made by the document editor mpi-5.0 For inclusion in the MPI 5.0 standard scheduled no-no vote No-No vote is scheduled for the next meeting scheduled reading Reading is scheduled for the next meeting
Milestone

Comments

@wgropp
Copy link

wgropp commented Mar 29, 2025

Problem

A few problems with the code checker were identified during the RC process.

Proposal

Fix the code checker (mpichk). The specific issues are:

  1. Add option to produce list of skipped code, so that it can be reviewed (there's been some errors found in skipped sections) Deferred.

  2. In mpichk.in, update to allow the lstlisting options caption and label

  3. Fix Unmatched ( in regex; marked by <-- HERE in m/([^{]){([^(])(
    <-- HERE (.)/ at ./mpicompilechk/mpichk line 542, line 1501.
    Relevant code is
    $es = substr($echars,0,1);
    $ee = substr($echars,1,1);
    while (/([^$es]
    )$es([^$ee])$ee(.)/) {

    This probably means a $ee contains an unescaped "(" character.
    Consider using quotemeta($es) and $ee

  4. p815. Add %%ERRONEOUS as mpichk option and use in this example. That could replace or augment the message option. Deferred

Changes to the Text

None

Impact on Implementations

None

Impact on Users

Better checks on the examples ensure a better document.

References and Pull Requests

See PR mpi-forum/mpi-standard/pull/1118, which addresses the issues not marked "Deferred"

@wgropp wgropp added the mpi-5.0 For inclusion in the MPI 5.0 standard label Mar 29, 2025
@github-project-automation github-project-automation bot moved this to To Do in MPI 5.0 Mar 29, 2025
@wgropp wgropp added the editor change Changes to be made by the document editor label Mar 29, 2025
@wesbland wesbland added the scheduled reading Reading is scheduled for the next meeting label Apr 14, 2025
@wesbland wesbland added this to the June 2025 milestone Apr 14, 2025
@wesbland wesbland added the scheduled no-no vote No-No vote is scheduled for the next meeting label Apr 14, 2025
@wesbland wesbland moved this from To Do to In Progress in MPI 5.0 Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor change Changes to be made by the document editor mpi-5.0 For inclusion in the MPI 5.0 standard scheduled no-no vote No-No vote is scheduled for the next meeting scheduled reading Reading is scheduled for the next meeting
Projects
Status: In Progress
Development

No branches or pull requests

2 participants