Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Undefined array key occurs in Text #2077

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

benquike
Copy link

Similar issue as discussed here
#1771

Verified

This commit was signed with the committer’s verified signature.
benquike Hui Peng
Similar issue as discussed here
mpdf#1771

Signed-off-by: Hui Peng <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
benquike Hui Peng
Signed-off-by: Hui Peng <[email protected]>
@benquike
Copy link
Author

can someone take a look at this?

@ssieb
Copy link

ssieb commented Jan 17, 2025

I can't really look at it, but I expect you'll need a test case that demonstrates the problem. See other PRs for how to do that.

@finwe
Copy link
Member

finwe commented Jan 17, 2025

  • It seems SetFont is not really an officially supported/documented method for mPDF, so its use can produce errors/unexpected outcomes
  • The correct method for mitigating this should be ensuring the sip key is always defined in internal font definitions
  • If the substitute font is really needed, please provide reasoning why and/or point to a precedent where the same procedure is used with other core fonts
  • As @ssieb mentioned, a test case is needed representing the error this is fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants