Skip to content

Bug 1998551 - Disable darwin/linux platforms for telemetry alerting. #9120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmierz merged 2 commits into from
Dec 11, 2025
+4 −5
Merged

Bug 1998551 - Disable darwin/linux platforms for telemetry alerting. #9120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
816c11f
Bug 1998551 - Disable darwin/linux platforms for telemetry alerting.
gmierz Dec 8, 2025
614a45d
Remove checks for platform, and completely ignore mobile probes.
gmierz Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions treeherder/perf/auto_perf_sheriffing/sherlock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,9 @@ def telemetry_alert(self):
repository = Repository.objects.get(name="mozilla-central")
framework = PerformanceFramework.objects.get(name="telemetry")
for metric_info in metric_definitions:
if metric_info["platform"] == "mobile":
# Skip mobile detection since it's currently broken
continue
if metric_info["name"] not in INITIAL_PROBES:
continue
try:
Expand All @@ -300,11 +303,7 @@ def telemetry_alert(self):
logger.info(f"Running detection for {probe.name}")
cdf_ts_detector = ts_detectors[probe.get_change_detection_technique()]

for platform in ("Windows", "Darwin", "Linux"):
if metric_info["platform"] == "mobile" and platform != "Mobile":
continue
elif metric_info["platform"] == "desktop" and platform == "Mobile":
continue
for platform in ("Windows",):
Copy link
Collaborator

@beatrice-acasandrei beatrice-acasandrei Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the current plan to add additional platforms, which is why we are keeping the for loop?

Copy link
Collaborator Author

@gmierz gmierz Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we plan on adding them back but it's unclear when. We need to get it working better from the mozdetect side first.

logger.info(f"On Platform {platform}")
try:
data = get_metric_table(
Expand Down