Count only unique failures #9104
Open
+130
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9104 +/- ##
==========================================
- Coverage 79.95% 79.93% -0.02%
==========================================
Files 600 600
Lines 32560 32575 +15
Branches 3310 3361 +51
==========================================
+ Hits 26032 26038 +6
- Misses 6362 6371 +9
Partials 166 166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
camd
force-pushed
the
camd/push-health-confirm-failure
branch
from
eefe817 to
fa17564
Compare
moijes12
reviewed
Dec 11, 2025
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def count_unique_test_failures(failures): |
Contributor
There was a problem hiding this comment.
This is correct. But since it is a utility function that is used at 3 places now (and may get used further), I think it would be nice to have a small unit test for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the counts in both Push Health, and the status lines in Treeherder for a push.