Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/ui/perfherder/alerts-view/status_dropdown_test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ const testStatusDropdown = (summaryTags, alertSummary) => {
repoModel={testRepoModel}
updateViewState={() => {}}
issueTrackers={testIssueTrackers}
bugTemplate={null}
filteredAlerts={testAlerts}
performanceTags={testPerformanceTags}
frameworks={[{ id: 1, name: dummyFrameworkName }]}
Expand Down
1 change: 1 addition & 0 deletions tests/webapp/api/test_performance_bug_template_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ def test_perf_bug_template_api(client, test_perf_framework):
"cc_list": f"foo{i}@bar.com",
"text": f"my great text {i}",
"critical_text": f"my great critical text {i}",
"no_action_required_text": f"my great text - no action is required from the author {i}",
}
PerformanceBugTemplate.objects.create(framework=framework, **dict)
dict["framework"] = framework.id
Expand Down
120 changes: 120 additions & 0 deletions treeherder/perf/fixtures/performance_bug_templates.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,18 @@
You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`

The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
no_action_required_text: |
Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}).

_**No action is required from the author; this comment is provided for informational purposes only.**_

{{ alertSummary }}

### Need Help or Information?

If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).

Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
- model: perf.PerformanceBugTemplate
pk: 2
fields:
Expand Down Expand Up @@ -74,6 +86,18 @@
You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`

The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
no_action_required_text: |
Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}).

_**No action is required from the author; this comment is provided for informational purposes only.**_

{{ alertSummary }}

### Need Help or Information?

If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).

Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
- model: perf.PerformanceBugTemplate
pk: 4
fields:
Expand Down Expand Up @@ -113,6 +137,18 @@
You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`

The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
no_action_required_text: |
Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}).

_**No action is required from the author; this comment is provided for informational purposes only.**_

{{ alertSummary }}

### Need Help or Information?

If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).

Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
- model: perf.PerformanceBugTemplate
pk: 5
fields:
Expand Down Expand Up @@ -152,6 +188,18 @@
You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`

The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
no_action_required_text: |
Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}).

_**No action is required from the author; this comment is provided for informational purposes only.**_

{{ alertSummary }}

### Need Help or Information?

If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).

Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
- model: perf.PerformanceBugTemplate
pk: 6
fields:
Expand Down Expand Up @@ -191,6 +239,18 @@
You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`

The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
no_action_required_text: |
Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}).

_**No action is required from the author; this comment is provided for informational purposes only.**_

{{ alertSummary }}

### Need Help or Information?

If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).

Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
- model: perf.PerformanceBugTemplate
pk: 7
fields:
Expand Down Expand Up @@ -230,6 +290,18 @@
You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`

The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
no_action_required_text: |
Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}).

_**No action is required from the author; this comment is provided for informational purposes only.**_

{{ alertSummary }}

### Need Help or Information?

If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).

Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
- model: perf.PerformanceBugTemplate
pk: 8
fields:
Expand Down Expand Up @@ -269,6 +341,18 @@
You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`

The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
no_action_required_text: |
Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}).

_**No action is required from the author; this comment is provided for informational purposes only.**_

{{ alertSummary }}

### Need Help or Information?

If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).

Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
- model: perf.PerformanceBugTemplate
pk: 9
fields:
Expand Down Expand Up @@ -308,6 +392,18 @@
You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`

The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
no_action_required_text: |
Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}).

_**No action is required from the author; this comment is provided for informational purposes only.**_

{{ alertSummary }}

### Need Help or Information?

If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).

Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
- model: perf.PerformanceBugTemplate
pk: 10
fields:
Expand Down Expand Up @@ -347,6 +443,18 @@
You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`

The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
no_action_required_text: |
Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}).

_**No action is required from the author; this comment is provided for informational purposes only.**_

{{ alertSummary }}

### Need Help or Information?

If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).

Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
- model: perf.PerformanceBugTemplate
pk: 11
fields:
Expand Down Expand Up @@ -386,3 +494,15 @@
You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`

The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
no_action_required_text: |
Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}).

_**No action is required from the author; this comment is provided for informational purposes only.**_

{{ alertSummary }}

### Need Help or Information?

If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).

Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Generated by Django 5.1.12 on 2025-10-26 16:46

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
("perf", "0061_performancedatum_os_name_and_more"),
]

operations = [
migrations.AddField(
model_name="performancebugtemplate",
name="no_action_required_text",
field=models.TextField(default="", max_length=4096),
),
]
1 change: 1 addition & 0 deletions treeherder/perf/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,7 @@ class PerformanceBugTemplate(models.Model):

text = models.TextField(max_length=4096)
critical_text = models.TextField(max_length=4096, default="")
no_action_required_text = models.TextField(max_length=4096, default="")

class Meta:
db_table = "performance_bug_template"
Expand Down
1 change: 1 addition & 0 deletions treeherder/webapp/api/performance_serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ class Meta:
"cc_list",
"text",
"critical_text",
"no_action_required_text",
]


Expand Down
4 changes: 0 additions & 4 deletions ui/perfherder/alerts/AlertTable.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,6 @@ export default class AlertTable extends React.Component {
issueTrackers,
fetchAlertSummaries,
updateViewState,
bugTemplate,
modifyAlert,
performanceTags,
} = this.props;
Expand Down Expand Up @@ -360,7 +359,6 @@ export default class AlertTable extends React.Component {
repoModel={repoModel}
updateViewState={updateViewState}
issueTrackers={issueTrackers}
bugTemplate={bugTemplate}
user={user}
filteredAlerts={filteredAlerts}
frameworks={frameworks}
Expand Down Expand Up @@ -533,7 +531,6 @@ AlertTable.propTypes = {
}).isRequired,
fetchAlertSummaries: PropTypes.func.isRequired,
updateViewState: PropTypes.func.isRequired,
bugTemplate: PropTypes.shape({}),
modifyAlert: PropTypes.func,
updateAlertSummary: PropTypes.func,
projects: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
Expand All @@ -543,7 +540,6 @@ AlertTable.propTypes = {
AlertTable.defaultProps = {
alertSummary: null,
issueTrackers: [],
bugTemplate: null,
modifyAlert: undefined,
// leverage dependency injection
// to improve code testability
Expand Down
3 changes: 0 additions & 3 deletions ui/perfherder/alerts/AlertsView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ class AlertsView extends React.Component {
optionCollectionMap: null,
count: 0,
id: validated.id,
bugTemplate: null,
totalPages: 0,
};
}
Expand Down Expand Up @@ -347,7 +346,6 @@ class AlertsView extends React.Component {
issueTrackers,
notSupportedAlertFilters,
optionCollectionMap,
bugTemplate,
page,
count,
} = this.state;
Expand Down Expand Up @@ -396,7 +394,6 @@ class AlertsView extends React.Component {
}
updateViewState={(state) => this.setState(state)}
setFiltersState={this.setFiltersState}
bugTemplate={bugTemplate}
user={user}
page={page}
count={count}
Expand Down
2 changes: 1 addition & 1 deletion ui/perfherder/alerts/AlertsViewControls.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export default class AlertsViewControls extends React.Component {
const framework = frameworkOptions.find(
(item) => item.name === selectedFramework,
);
updateViewState({ bugTemplate: null, page: 1 });
updateViewState({ page: 1 });
setFiltersState({ framework }, this.fetchAlertSummaries);
};

Expand Down
Loading