Pcf 634 new stats analysis #8944
Conversation
|
hi @beatrice-acasandrei, when you get a chance will you eye my draft PR? The return object for the new stats method is still pretty big but I can remove stuff that are extraneous once we are firm on what information we want to display on the front-end. |
misspran
force-pushed
the
PCF-634-new-stats-analysis
branch
3 times, most recently
from
682727b to
167f5c8
Compare
|
@beatrice-acasandrei I added a 2nd serializer as suggested. I still need to add more tests but if you don't mind taking a glance at the changes |
|
@beatrice-acasandrei I think bugs should be fixed and updated. I've also grouped the return values based on your feedback and updated the serializer. |
misspran
force-pushed
the
PCF-634-new-stats-analysis
branch
from
e39936a to
e5148d0
Compare
requirements/common.in
Outdated
|
|
||
| # Statistical methods for performance analysis | ||
| scipy==1.15.3 | ||
| numpy==2.2.6 |
There was a problem hiding this comment.
Could we see if we can remove the numpy/scipy requirements? We already have numpy and scipy and a major version update to numpy could be problematic for other tooling.
If needed, we could also try downgrading the cliffs-delta/kdepy ones to match the versions of numpy we currently have.
requirements/dev.in
Outdated
| urllib3==2.0.3 | ||
|
|
||
| # Statistical methods for performance analysis | ||
| scipy==1.15.3 |
There was a problem hiding this comment.
I think this file contains requirements needed for testing specifically. They should already be covered by the requirements/common.in file so I believe you can remove them from here.
misspran
force-pushed
the
PCF-634-new-stats-analysis
branch
from
bc36d7a to
40ec5eb
Compare
remove changes to numpy and scipy
Remove kdepy and cliffs-delta from dev
Remove kdepy and cliffsdelta from dev
I added a draft in hopes of getting some eyes on the stats code.