-
Notifications
You must be signed in to change notification settings - Fork 369
Intermittent failures filter #8760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6fe3a59
to
4abfef3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing this locally, I enjoyed seeing the option for selecting multiple items, this worked well.
the problem I had was after selecting a few items, I ended up wanting to remove some and it was hard to see what was set and not as it didn't expand visually.
I would like to get this working for components also.
4abfef3
to
408cb3b
Compare
@jmaher I added the filter to 'component' and expanded the viewing area to make deletion easier. |
408cb3b
to
12b8336
Compare
@jmaher fixed. Can you try again please ? |
this is looking a lot better. I like that the drop down pops up a clean looking list with checkboxes, and when clicking it, you can see what is checked. The items that are shown are basically a single letter and a X, due to the lack of pixels. I found opening the list and checking/unchecking was most effective. This brings up a decision to make:
I think a user would expect #1, but #2 seems more useful. If #1 isn't possible to do, then I am fine with #2. This doesn't need to be perfect, just not confusing. |
12b8336
to
9f18422
Compare
I think solution #1 is not possible. So I opted for solution #2. |
9f18422
to
478fea6
Compare
No description provided.