Skip to content

Intermittent failures filter #8760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

djangoliv
Copy link
Contributor

No description provided.

@djangoliv djangoliv force-pushed the intermittent-failures-filter branch 4 times, most recently from 6fe3a59 to 4abfef3 Compare June 12, 2025 07:54
Copy link
Collaborator

@jmaher jmaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing this locally, I enjoyed seeing the option for selecting multiple items, this worked well.

the problem I had was after selecting a few items, I ended up wanting to remove some and it was hard to see what was set and not as it didn't expand visually.

I would like to get this working for components also.

@djangoliv djangoliv force-pushed the intermittent-failures-filter branch from 4abfef3 to 408cb3b Compare June 13, 2025 08:28
@djangoliv
Copy link
Contributor Author

@jmaher I added the filter to 'component' and expanded the viewing area to make deletion easier.

@jmaher
Copy link
Collaborator

jmaher commented Jun 13, 2025

thanks for adding it to the components. There is still an issue with the editing:
Screenshot 2025-06-13 102257

@djangoliv djangoliv force-pushed the intermittent-failures-filter branch from 408cb3b to 12b8336 Compare June 18, 2025 09:44
@djangoliv
Copy link
Contributor Author

thanks for adding it to the components. There is still an issue with the editing: Screenshot 2025-06-13 102257

@jmaher fixed. Can you try again please ?

@jmaher
Copy link
Collaborator

jmaher commented Jun 18, 2025

this is looking a lot better. I like that the drop down pops up a clean looking list with checkboxes, and when clicking it, you can see what is checked.

The items that are shown are basically a single letter and a X, due to the lack of pixels. I found opening the list and checking/unchecking was most effective.

This brings up a decision to make:

  1. show the full name of checked items?
  2. don't show any names, just an indicator something is checked and only use the popup list

I think a user would expect #1, but #2 seems more useful. If #1 isn't possible to do, then I am fine with #2. This doesn't need to be perfect, just not confusing.

@djangoliv djangoliv force-pushed the intermittent-failures-filter branch from 12b8336 to 9f18422 Compare June 19, 2025 12:12
@djangoliv
Copy link
Contributor Author

this is looking a lot better. I like that the drop down pops up a clean looking list with checkboxes, and when clicking it, you can see what is checked.

The items that are shown are basically a single letter and a X, due to the lack of pixels. I found opening the list and checking/unchecking was most effective.

This brings up a decision to make:

1. show the full name of checked items?

2. don't show any names, just an indicator something is checked and only use the popup list

I think a user would expect #1, but #2 seems more useful. If #1 isn't possible to do, then I am fine with #2. This doesn't need to be perfect, just not confusing.

I think solution #1 is not possible. So I opted for solution #2.

@djangoliv djangoliv force-pushed the intermittent-failures-filter branch from 9f18422 to 478fea6 Compare June 19, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants