Add support for language detection.

mozilla · Dec 18, 2018 · 66397fb · 66397fb
1 parent 73dfd06
commit 66397fb
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/parser.js b/parser.js
@@ -134,6 +134,16 @@ const metadataRuleSets = {
     ],
   },
 
+  language: {
+    rules: [
+      ['html[lang]', element => element.getAttribute('lang')],
+      ['meta[name="language" i]', element => element.getAttribute('content')],
+    ],
+    processors: [
+      (language, context) => language.split('-')[0]
+    ]
+  },
+
   type: {
     rules: [
       ['meta[property="og:type"]', element => element.getAttribute('content')],

diff --git a/tests/getMetadata.test.js b/tests/getMetadata.test.js
@@ -35,9 +35,11 @@ describe('Get Metadata Tests', function() {
   const sampleType = 'article';
   const sampleUrl = 'http://www.example.com/';
   const sampleProviderName = 'Example Provider';
+  const sampleLanguage = 'en';
+
 
   const sampleHtml = `
-    <html>
+    <html lang="en-CA">
     <head>
       <meta property="og:description" content="${sampleDescription}" />
       <link rel="icon" href="${sampleIcon}" />
@@ -63,6 +65,8 @@ describe('Get Metadata Tests', function() {
     assert.equal(metadata.type, sampleType, `Unable to find ${sampleType} in ${sampleHtml}`);
     assert.equal(metadata.url, sampleUrl, `Unable to find ${sampleUrl} in ${sampleHtml}`);
     assert.equal(metadata.provider, sampleProviderName, `Unable to find ${sampleProviderName} in ${sampleHtml}`);
+    assert.equal(metadata.language, sampleLanguage, `Unable to find ${sampleLanguage} in ${sampleHtml}`);
+
   });
 
   it('uses absolute URLs when url parameter passed in', () => {
@@ -164,6 +168,21 @@ describe('Get Metadata Tests', function() {
 
   });
 
+  it('finds language in metadata', () => {
+    const html = `
+      <html>
+      <head>
+        <meta name="language" content="en-CA" />
+      </head>
+      </html>
+    `;
+
+    const doc = stringToDom(html);
+    const metadata = getMetadata(doc, sampleUrl, metadataRuleSets);
+
+    assert.equal(metadata.language, sampleLanguage, `Unable to find ${sampleLanguage} in ${html}`);
+  });
+
   it('allows custom rules', () => {
     const doc = stringToDom(sampleHtml);
     const rules = {