This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
chore(project): remove the validator dependency #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladikoff
approved these changes
Jun 6, 2018
| struct Email { | ||
| #[validate(email)] | ||
| #[serde(deserialize_with = "deserialize::email_address")] |
| @@ -43,7 +41,7 @@ struct Email { | |||
| } | |||
|
|
|||
| impl FromData for Email { | |||
| type Error = ValidationError; | |||
| type Error = (); | |||
There was a problem hiding this comment.
I guess this will be changed once we use the suggested error crates?
There was a problem hiding this comment.
Possibly, although I think it's more contingent on a resolution to rwf2/Rocket#596 tbh.
| @@ -25,9 +25,6 @@ extern crate serde; | |||
| #[macro_use] | |||
| extern crate serde_derive; | |||
| extern crate serde_json; | |||
| extern crate validator; | |||
| #[macro_use] | |||
| extern crate validator_derive; | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41.
Since we got the sprauncy new regex in #45, I decided to quickly whip out this dependency right away. It's been annoying me for a while.
@mozilla/fxa-devs r?