chore(o11y): update server jobs to use structured logging #6387
+168
−273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinnl
approved these changes
Jan 5, 2026
Collaborator
Vinnl
left a comment
Vinnl
left a comment
There was a problem hiding this comment.
Thanks for updating this!
Usually I'm the only one of the team who cares/would take advantage of this in the future, so this is not a blocker and I'm not going to keep bringing this up, but... Personally, I would have used several separate commits that can be rolled back independently, and git blamed for more info. But again, I acknowledge that that is extra work that's not worth it if it only benefits me.
| export async function getBreachIcons(breaches: HibpGetBreachesResponse) { | ||
| // make logofolder if it doesn't exist | ||
| // TODO: clean up unused folder and existing logo logic | ||
| // MNTOR-5166 |
Collaborator
There was a problem hiding this comment.
Praise: thanks for filing this one, good improvements there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-5099
Figma:
Description
Update server jobs to use structured logs. Does not apply to frontend/next console statements, since the frontend can't use winston. If we want to update frontend logging w should discuss implementation as a team.