Define the ENV setting for all environments (including test/build/local) #23073
+47
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15358
Description
Defines a gloabl ENV setting and documents its purpose and meaning.
Testing
You can inspect for build,test,local.
Build
Anywhere in the dockerfile add
RUN echo "env: ${ENV}"
Run the build
Expect to see "env: build"
Test
In any test add
Expect both to print "test"
Local
run
make down && make up
(to ensure new compose settings are appliedCheck in the terminal
make shell
printenv
Expect ENV=local in there
Check in settings
make djshell
settings.ENV
Expect "local" to be returned
Screenshots
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.