Change Wording of Escalated Appeals in Version History #22972
Conversation
chrstinalin
requested review from
a team and
eviljeff
and removed request for
a team
src/olympia/abuse/cinder.py
Outdated
| 'dsa-appeals-review' | ||
| if appeal | ||
| else 'dsa-cinder-forwarded-review' | ||
| 'dsa-cinder-forwarded-review' | ||
| if forwarded | ||
| else 'dsa-appeals-review' | ||
| if appeal |
There was a problem hiding this comment.
mmm, was this change necessary?
There was a problem hiding this comment.
If CINDER_APPEAL_ESCALATION is meant to behave virtually identical to CINDER_ESCALATION (beyond the history), it would make sense for this waffle switch name to be the same, no? If it's the other way around, CINDER_APPEAL_ESCALATION would have 'dsa-appeals-review' as the name instead.
There was a problem hiding this comment.
I can see the logic (and don't disagree), but one of reasons we have these series of waffles switches it the rollout is being phased, and reviewers handling appeals is a later phase than handling forwarded reports. So for now I we're going to have to stick with the inconsistency.
src/olympia/abuse/cinder.py
Outdated
| 'dsa-appeals-review' | ||
| if appeal | ||
| else 'dsa-cinder-forwarded-review' | ||
| 'dsa-cinder-forwarded-review' | ||
| if forwarded | ||
| else 'dsa-appeals-review' | ||
| if appeal |
There was a problem hiding this comment.
I can see the logic (and don't disagree), but one of reasons we have these series of waffles switches it the rollout is being phased, and reviewers handling appeals is a later phase than handling forwarded reports. So for now I we're going to have to stick with the inconsistency.
| NeedsHumanReview.REASONS.CINDER_ESCALATION, | ||
| NeedsHumanReview.REASONS.CINDER_APPEAL_ESCALATION, |
There was a problem hiding this comment.
There could be a follow-up to break these out - so they can be filtered separately - but this is fine for now.
src/olympia/users/utils.py
Outdated
| return UserProfile.objects.get(pk=settings.TASK_USER_ID) | ||
| try: | ||
| return UserProfile.objects.get(pk=settings.TASK_USER_ID) | ||
| except UserProfile.DoesNotExist: | ||
| return None |
There was a problem hiding this comment.
We don't want this change - if there's a test failing because the task user doesn't exist, just create a user profile with TASK_USER_ID as the id in the test. (use user_factory)
Fixes: mozilla/addons#14809
Description
Adds CINDER_APPEAL_ESCALATION to distinguish appeal escalations.
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.