Move to Poetry for Python #1586
Conversation
| [tool.poetry] | ||
| name = "syncstorage-rs" | ||
| version = "0.1.0" | ||
| description = "sync storage server in rust" |
There was a problem hiding this comment.
There's a potential that folk might discover this package while looking for a stand-alone Sync storage server. Let's be exceptionally clear about what this is and how it's being used.
| description = "sync storage server in rust" | |
| description = "Support package for the Mozilla Sync storage server, written in rust. This is not a 'stand alone' server and is not meant for general use to run your own Sync storage server. Please see [the wiki page](https://github.com/mozilla-services/syncstorage-rs/wiki/overview) for further details." |
taddes
force-pushed
the
SYNC-4293_poetry_deps_mgmt
branch
from
b8c0ff2
to
2aa78e2
Compare
taddes
force-pushed
the
SYNC-4293_poetry_deps_mgmt
branch
from
d7af2bd
to
fa1df48
Compare
taddes
force-pushed
the
SYNC-4293_poetry_deps_mgmt
branch
from
a3673b2
to
c20fcb1
Compare
| ) | ||
| writer = DataFileWriter( | ||
| open(out_file_name, "wb"), DatumWriter(), schema) | ||
| for chunk in range(max(1, math.trunc(math.ceil(row_count / MAX_ROWS)))): |
There was a problem hiding this comment.
Yeah, i'd have words with the folk behind black and why they want python to look like perl, but 🤷🏻
| """ group by userid order by userid""".format( | ||
| bso_num)) | ||
| sql = ( | ||
| """select userid, count(*) as count from bso{}""" |
There was a problem hiding this comment.
Your call, but we could probably reformat this to make it more "black" like:
| """select userid, count(*) as count from bso{}""" | |
| f"""select userid, count(*) as count from bso{bso_num}""" | |
| """ group by userid order by userid""" |
tools/spanner/purge_ttl.py
Outdated
| result = database.execute_partitioned_dml(query, params=params, param_types=param_types) | ||
| result = database.execute_partitioned_dml( | ||
| query, params=params, param_types=param_types | ||
| ) | ||
| end = datetime.now() | ||
| logging.info( | ||
| "{name}: removed {result} rows, {name}_duration: {time}, prefix: {prefix}".format( |
There was a problem hiding this comment.
Again, purely optional, but we could redo this as an f"" string.
There was a problem hiding this comment.
Agreed. Just noting that given this change creates a lot of formatting changes, I tried to limit them best I could and get the tools in place to help, all while at least respecting flake8. We can tackle the remainder of these when we are past the priority issues, but I'll add this one in.
| @@ -87,35 +86,24 @@ def purge_old_records( | |||
| range_msg = "" | |||
| if uid_range: | |||
| range_msg = ( | |||
| f" within range {uid_range[0] or 'Start'}" | |||
| f" to {uid_range[1] or 'End'}" | |||
| f" within range {uid_range[0] or 'Start'}" f" to {uid_range[1] or 'End'}" | |||
There was a problem hiding this comment.
Ok, odd format.
Let's just join these two f"" strings and maybe we can drop the parens?
… matching between subdirectories
taddes
force-pushed
the
SYNC-4293_poetry_deps_mgmt
branch
from
c20fcb1
to
8d649a8
Compare
|
Thanks for the comments @jrconlin . I shelved this one before MozWeek, but I don't think it hurts to merge in now, we can pick up the steps later once we've finished our priority tasks. All the parts are there to utilize the tooling with some format improvements, we'll just make the move to Poetry (officially, should we wish) down the road. |
Description
Update to Poetry for Python dependency management.
This puts all the tools, dependencies, and commands in place. However, we won't spin our wheels right now converting over in CI, moving from venv and whatnot, since we're not prioritizing Sync modernization atm. We will address down the road, but for the time being increases developer speed and experience for checks and makes some improvements to the python utilities.
Benefits:
Testing
How should reviewers test?
Issue(s)
Closes 4293.