Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FXIOS [Dependencies] Glean to 62.0.0 #23695

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

lmarceau
Copy link
Contributor

📜 Tickets

No tickets

💡 Description

Bump Glean to 62.0.0

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@lmarceau lmarceau requested a review from a team as a code owner December 11, 2024 20:00
Copy link
Contributor

@rvandermeulen rvandermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns with the current Glean release in AppServices 134+. Given Glean's semver usage, I'm actually a bit surprised that things haven't been broken with 61.2.0 here and 62.0.0 in the same A-S build. Might be a good idea to backport this to release/v134 just to be safe, though.

@rvandermeulen
Copy link
Contributor

rvandermeulen commented Dec 11, 2024

As discussed on Slack, I don't think bumping the Glean parser version is strictly necessary since pip install is using a ~= operator and should use the highest-available 15.x build anyway, but I don't think it'll hurt anything. And it'll be moot soon since Glean v63.0.0 will be landing in AppServices shortly and bumping the Glean parser major version to 16 as part of that.

@mobiletest-ci-bot
Copy link

Messages
📖 Edited 5 files
📖 Created 0 files

Generated by 🚫 Danger Swift against 3d5ecc4

@lmarceau
Copy link
Contributor Author

@Mergifyio backport release/v134

Copy link
Contributor

mergify bot commented Dec 11, 2024

backport release/v134

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants