Refactor FXIOS-10669, Subtask FXIOS-10820 [Sent from Firefox] Improve share "extension" type names and add documentation

[ih-codes]

📜 Tickets

Jira ticket
Github issue

Jira Subtask FXIOS-10820

💡 Description

This PR is part of the Sent from Firefox / Info Card Referral experiment work, which involves refactoring our old share sheet code.

This PR:

• Renames ShareExtensionHelper -> ShareManager
• Renames ShareExtensionCoordinator -> ShareSheetCoordinator
• Updates related naming for any variables, properties, functions, etc. with the word "shareExtension"
• Adds documentation
• Updates the sharesheet route to take a ShareType and ShareMessage instead of a URL and title

Note: The .sharesheet route was only just added for the Info Card Referral experiment here (https://github.com/mozilla-mobile/firefox-ios/pull/23094/files) and isn't in use yet. My next PR will hook things up again, I just didn't want too much clutter.

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed, I updated documentation / comments for complex code and public methods
• If needed, added a backport comment (example @Mergifyio backport release/v120)

[ih-codes]

Updated PR description.

[ih-codes]

(This was just moved lower in the file)

[ih-codes]

Fixing 1 thing on the branch atm, getting infinite recursion from one of the renaming! 😆

[ih-codes]

Fixing 1 thing on the branch atm, getting infinite recursion from one of the renaming! 😆

Alright this has been fixed! There was a protocol with default implementation that was just calling itself since I didn't rename it and/or remove it properly.

[mobiletest-ci-bot]

	Messages
📖	Project coverage: 33.63%
📖	Edited 22 files
📖	Created 0 files

Client.app: Coverage: 31.51

File	Coverage
BrowserViewController.swift	3.54%	⚠️
BrowserCoordinator.swift	69.15%	✅
HomepageContextMenuHelper.swift	3.19%	⚠️
LibraryCoordinator.swift	86.9%	✅
MainMenuActionHelper.swift	0.0%	⚠️
BrowserNavigationHandler.swift	0.0%	⚠️
ShareManager.swift	75.63%	✅
RouteBuilder.swift	88.7%	✅
ShareSheetCoordinator.swift	32.3%	⚠️
ActionProviderBuilder.swift	0.0%	⚠️
DownloadsPanel.swift	36.94%	⚠️
DownloadsCoordinator.swift	65.12%	✅
Route.swift	100.0%	✅

Generated by 🚫 Danger Swift against cb01346

[mergify]

This pull request has conflicts when rebasing. Could you fix it @ih-codes? 🙏

[MattLichtenstein]

Looks good 👍

Only thing I would change is the following in the PR description:

Renames ShareExtensionCoordinator -> ShareCoordinator

Renames ShareExtensionCoordinator -> ShareSheetCoordinator

[ih-codes]

Looks good 👍

Only thing I would change is the following in the PR description:

Renames ShareExtensionCoordinator -> ShareCoordinator

Renames ShareExtensionCoordinator -> ShareSheetCoordinator

Thanks @MattLichtenstein, done! I missed that when I had to write up the PR description a second time after the GitHub incident. 😭