Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10780 - [Toolbar design][Accessibility] Accessible name of tabs icon button should match annotations #23531

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Bugfix FXIOS-10780 - [Toolbar design][Accessibility] Accessible name of tabs icon button should match annotations #23531

merged 4 commits into from
Dec 11, 2024

Conversation

PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented Dec 3, 2024 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Adds a11y label for the toolbar redesign tabs button.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@PARAIPAN9 PARAIPAN9 requested a review from thatswinnie December 3, 2024 14:02
@PARAIPAN9 PARAIPAN9 requested a review from a team as a code owner December 3, 2024 14:02
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Dec 3, 2024 •
edited
Loading

Messages
📖 Project coverage: 33.48%
📖 Edited 11 files
📖 Created 0 files

Client.app: Coverage: 31.87

File Coverage
AddressBarState.swift 90.4% ✅
NavigationBarState.swift 4.93% ⚠️

Generated by 🚫 Danger Swift against bdec5c2

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 10, 2024

This pull request has conflicts when rebasing. Could you fix it @PARAIPAN9? 🙏

@dragosb01 dragosb01 requested a review from a team as a code owner December 11, 2024 12:13
@dragosb01 dragosb01 requested a review from jjSDET December 11, 2024 12:13
@isabelrios isabelrios removed the request for review from jjSDET December 11, 2024 13:05
@PARAIPAN9 PARAIPAN9 merged commit bc1a8c1 into main Dec 11, 2024
12 of 13 checks passed
@PARAIPAN9 PARAIPAN9 deleted the sparaipan/fxios-10780-Accessible-name-of-tabs-icon-button-should-match-annotations branch December 11, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelrios isabelrios isabelrios approved these changes

@thatswinnie thatswinnie thatswinnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PARAIPAN9 @mobiletest-ci-bot @thatswinnie @isabelrios @dragosb01