Add FXIOS-10007 [Bookmarks Evolution] Add sign in button to empty state #23442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmarceau
reviewed
Dec 2, 2024
| @@ -182,6 +221,26 @@ class BookmarksCoordinator: BaseCoordinator, | |||
| return controller | |||
| } | |||
|
|
|||
| private func makeSignInController() -> UIViewController { | |||
| let fxaParams = FxALaunchParams(entrypoint: .libraryPanel, query: [:]) | |||
| // NEED TO CHANGE PARENT TYPE | |||
There was a problem hiding this comment.
still todo?
Suggested change
| // NEED TO CHANGE PARENT TYPE |
| key: "Bookmarks.EmptyState.Root.ButtonTitle.v135", | ||
| tableName: "Bookmarks", | ||
| value: "Sign in to Sync", | ||
| comment: "The button title for the sign in button on the placeholder screen shown when there are no saved bookmarks, located at the root level of the bookmarks panel within the libray modal. This button starts the initiates allowing users to sign in to their Mozilla Account to sync data") |
There was a problem hiding this comment.
Typo + I am not sure I get the sentence "This button starts the initiates [...]"
Suggested change
| comment: "The button title for the sign in button on the placeholder screen shown when there are no saved bookmarks, located at the root level of the bookmarks panel within the libray modal. This button starts the initiates allowing users to sign in to their Mozilla Account to sync data") | |
| comment: "The button title for the sign in button on the placeholder screen shown when there are no saved bookmarks, located at the root level of the bookmarks panel within the library modal. This button starts the flow allowing users to sign in to their Mozilla Account to sync data") |
There was a problem hiding this comment.
woah, yea I don't understand what I was going for there either 😂
lmarceau
approved these changes
Dec 3, 2024
MattLichtenstein
force-pushed
the
ml/FXIOS-9742_bookmarks-empty-state-sign-in-flow
branch
from
0797c41 to
e41f37a
Compare
MattLichtenstein
had a problem deploying
to
github-pages
GitHub Actions
Failure
This reverts commit e151b0a.
Client.app: Coverage: 31.46
Generated by 🚫 Danger Swift against 6d5d1bd |
MattLichtenstein
deleted the
ml/FXIOS-9742_bookmarks-empty-state-sign-in-flow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
📝 Notes:
FirefoxAccountSignInViewControlleris presented as a fullscreen modal for consistency with the remote tabs panel sign in flow📷 Screenshots
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)