Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-10362 - Enable address autofill edit by default on US and CA (backport #23256) #23337

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Add FXIOS-10362 - Enable address autofill edit by default on US and CA (backport #23256) #23337

merged 1 commit into from
Dec 3, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 22, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR:

  • Enables address edit by default on US and CA or if user is enrolled in an experiment that enables it.

⚠️ NOTE1: I am intentionally not removing the nimbus flag because we intend to rollout this feature to other locales soon.
⚠️ NOTE2: This needs to be backported to 133.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #23256 done by [Mergify](https://mergify.com).

@issammani @mergify
Add FXIOS-10362 - Enable address autofill edit by default on US and CA (
158710e 
#23256)

chore: enable address edit by default on US and CA
(cherry picked from commit 6e1f58c)
@mergify mergify bot requested a review from a team as a code owner November 22, 2024 20:23
@mergify mergify bot requested review from mattreaganmozilla and removed request for a team November 22, 2024 20:23
@mergify mergify bot mentioned this pull request Nov 22, 2024
Merged
6 tasks
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.27%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 30.67

File Coverage
AddressListViewModel.swift 46.08% ⚠️

Generated by 🚫 Danger Swift against 158710e

@issammani issammani added the weekly-release Tagging backports for rapid release label Nov 22, 2024
DonalMe
DonalMe approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@DonalMe DonalMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for 133.1

@DonalMe DonalMe merged commit 9d29838 into release/v133 Dec 3, 2024
12 checks passed
@DonalMe DonalMe deleted the mergify/bp/release/v133/pr-23256 branch December 3, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattreaganmozilla mattreaganmozilla mattreaganmozilla approved these changes

@DonalMe DonalMe DonalMe approved these changes

Assignees
No one assigned
Labels
weekly-release Tagging backports for rapid release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mobiletest-ci-bot @DonalMe @mattreaganmozilla @issammani