Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - auto update credential provider script #22606

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Oct 17, 2024

Messages
📖 Edited 6 files
📖 Created 1 files

Generated by 🚫 Danger Swift against 03f8101

@isabelrios
Copy link
Contributor

@issammani there is a UI test failing consistently in this PR: testAutofillCreditCardsToggleOnOff() with error:
firefox-ios/firefox-ios-tests/Tests/XCUITests/BaseTestCase.swift:157 - failed - Timed out waiting for element "KeyboardAccessory.creditCardAutofillButton" Button to exist

Could it be due to changes in this PR? Thanks!

@issammani
Copy link
Collaborator

@issammani there is a UI test failing consistently in this PR: testAutofillCreditCardsToggleOnOff() with error: firefox-ios/firefox-ios-tests/Tests/XCUITests/BaseTestCase.swift:157 - failed - Timed out waiting for element "KeyboardAccessory.creditCardAutofillButton" Button to exist

Could it be due to changes in this PR? Thanks!

@isabelrios Thanks for the ping. Nothing stands out from the changes in this PR. I'll check it locally now 😄

@issammani
Copy link
Collaborator

@isabelrios AddressParser.sys.mjs was missing from the shared files. I added that in 03f8101. That should fix it 😄

@isabelrios
Copy link
Contributor

@isabelrios AddressParser.sys.mjs was missing from the shared files. I added that in 03f8101. That should fix it 😄

Great, thank you! 🤞

@issammani
Copy link
Collaborator

@isabelrios I think it fixed it, now the failure is in testOpenLinkFromPDF which is not related this. I think this good to merge ?

@isabelrios
Copy link
Contributor

@isabelrios I think it fixed it, now the failure is in testOpenLinkFromPDF which is not related this. I think this good to merge ?

Yes! that test passed in re-try. Bitrise general check is green now! thanks for the fix!

@issammani issammani merged commit 64c86e7 into main Oct 17, 2024
10 of 11 checks passed
@issammani issammani deleted the update-cred-provider-script branch October 17, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants