Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-7324 [v121.1] Add missing credit card option for FxA syncing in the choose what to sync list (backport #17678) #17813

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 18, 2023

This is an automatic backport of pull request #17678 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…yncing in the choose what to sync list (#17678)

* Refactor FXIOS-7324 [v121] Add missing credit card option for FxA syncing in the choose what to sync list

* Added credit card feature flag as part of it as well

(cherry picked from commit 813fa63)
@mergify mergify bot requested a review from a team as a code owner December 18, 2023 21:15
@mergify mergify bot requested review from lmarceau and removed request for a team December 18, 2023 21:15
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 34.51%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 31.9

File Coverage
FxAWebViewModel.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against a0e6508

@lmarceau lmarceau requested review from nbhasin2 and removed request for lmarceau December 18, 2023 21:41
@lmarceau lmarceau added the weekly-release Tagging backports for rapid release label Dec 18, 2023
Copy link
Contributor

@rvandermeulen rvandermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for 121.1

@rvandermeulen rvandermeulen merged commit 57df525 into release/v121 Jan 1, 2024
9 of 10 checks passed
@rvandermeulen rvandermeulen deleted the mergify/bp/release/v121/pr-17678 branch January 1, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
weekly-release Tagging backports for rapid release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants