Refactor - auto update credential provider script (#23469)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mozilla-mobile · Nov 29, 2024 · 38f7c92 · 38f7c92
1 parent eb615fa
commit 38f7c92
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 54 deletions.
diff --git a/firefox-ios/Client/Assets/CC_Script/AutofillTelemetry.sys.mjs b/firefox-ios/Client/Assets/CC_Script/AutofillTelemetry.sys.mjs
@@ -230,14 +230,6 @@ class AutofillTelemetryBase {
     throw new Error("Not implemented.");
   }
 
-  recordDetectedSectionCount() {
-    throw new Error("Not implemented.");
-  }
-
-  recordSubmittedSectionCount(_count) {
-    throw new Error("Not implemented.");
-  }
-
   recordNumberOfUse(records) {
     let histogram = Services.telemetry.getKeyedHistogramById(
       this.HISTOGRAM_PROFILE_NUM_USES
@@ -369,18 +361,6 @@ export class AddressTelemetry extends AutofillTelemetryBase {
   recordAutofillProfileCount(count) {
     Glean.formautofillAddresses.autofillProfilesCount.set(count);
   }
-
-  recordDetectedSectionCount() {
-    Glean.formautofillAddresses.detectedSectionsCount.add(1);
-  }
-
-  recordSubmittedSectionCount(count) {
-    if (!count) {
-      return;
-    }
-
-    Glean.formautofillAddresses.submittedSectionsCount.add(count);
-  }
 }
 
 class CreditCardTelemetry extends AutofillTelemetryBase {
@@ -436,18 +416,6 @@ class CreditCardTelemetry extends AutofillTelemetryBase {
   recordAutofillProfileCount(count) {
     Glean.formautofillCreditcards.autofillProfilesCount.set(count);
   }
-
-  recordDetectedSectionCount() {
-    Glean.formautofillCreditCards.detectedSectionsCount.add(1);
-  }
-
-  recordSubmittedSectionCount(count) {
-    if (!count) {
-      return;
-    }
-
-    Glean.formautofillCreditCards.submittedSectionsCount.add(count);
-  }
 }
 
 export class AutofillTelemetry {
@@ -512,22 +480,6 @@ export class AutofillTelemetry {
     telemetry.recordFormInteractionEvent(method, flowId, fieldDetails, data);
   }
 
-  /**
-   * Utility functions for submitted section count scalar (defined in Scalars.yaml)
-   *
-   * Category: formautofill.creditCards or formautofill.addresses
-   * Scalar name: submitted_sections_count
-   */
-  static recordDetectedSectionCount(fieldDetails) {
-    const telemetry = this.#getTelemetryByFieldDetail(fieldDetails[0]);
-    telemetry.recordDetectedSectionCount();
-  }
-
-  static recordSubmittedSectionCount(fieldDetails, count) {
-    const telemetry = this.#getTelemetryByFieldDetail(fieldDetails[0]);
-    telemetry.recordSubmittedSectionCount(count);
-  }
-
   static recordManageEvent(type, method) {
     const telemetry = this.#getTelemetryByType(type);
     telemetry.recordManageEvent(method);

diff --git a/firefox-ios/Client/Assets/CC_Script/FormAutofillSection.sys.mjs b/firefox-ios/Client/Assets/CC_Script/FormAutofillSection.sys.mjs
@@ -350,7 +350,6 @@ export class FormAutofillSection {
       return;
     }
 
-    lazy.AutofillTelemetry.recordDetectedSectionCount(this.fieldDetails);
     lazy.AutofillTelemetry.recordFormInteractionEvent(
       "detected",
       this.flowId,
@@ -388,7 +387,6 @@ export class FormAutofillSection {
   onSubmitted(formFilledData) {
     this.submitted = true;
 
-    lazy.AutofillTelemetry.recordSubmittedSectionCount(this.fieldDetails, 1);
     lazy.AutofillTelemetry.recordFormInteractionEvent(
       "submitted",
       this.flowId,

diff --git a/firefox-ios/Client/Assets/CC_Script/Helpers.ios.mjs b/firefox-ios/Client/Assets/CC_Script/Helpers.ios.mjs
@@ -191,11 +191,9 @@ window.Localization = function () {
 // dispatches telemetry messages to the iOS, we need to modify typedefs in swift. For now, we map the telemetry events
 // to the expected shape. FXCM-935 will tackle cleaning this up.
 window.Glean = {
-  // TODO(FXCM-1453): While moving away from legacy scalars to glean ones, the automated script generated
-  // an additional category `formautofill.credit_cards`. This resulted into two different methods in our code
-  // with different casing for the c in Credit(c|C)ards. This is a temp fix until FXCM-1453 happens.
+  // While moving away from Legacy Telemetry to Glean, the automated script generated the additional categories
+  // `creditcard` and `address`. After bug 1933961 all probes will have moved to category formautofillCreditcards and formautofillAddresses.
   formautofillCreditcards: undefinedProxy(),
-  formautofillCreditCards: undefinedProxy(),
   formautofill: undefinedProxy(),
   creditcard: undefinedProxy(),
   _mapGleanToLegacy: (eventName, { value, ...extra }) => {
@@ -237,6 +235,8 @@ window.Glean = {
       },
     }
   ),
+  // Keeping unused category formautofillAddresses here, because Bug 1933961
+  // will move probes from the glean category address to formautofillAddresses
   formautofillAddresses: undefinedProxy(),
 };