Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved file handling especially property file #644

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

volkm
Copy link
Contributor

@volkm volkm commented Dec 11, 2024

  • Consistently use openFile / closeFile helper functions
  • Introduce namespace storm::io for all files in storm/io
  • Warn if a property string looks like a link to a property file but the file does not exist (Resolves Confusing error message for --prop option #643). The check warns if the property strings contains any of .prop, .prctl, .pctl or .csl (following the Prism documentation)

@volkm
Copy link
Contributor Author

volkm commented Dec 11, 2024

Each call to parseProperties currently checks whether a potential file with this name exists. File I/O operations can be costly and this can introduce some unnecessary overhead. I would suggest to add dedicated functions for parsePropertiesFromString and parsePropertiesFromFile to avoid this overhead if the input format is clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error message for --prop option
1 participant