Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump build system #598

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Bump build system #598

merged 6 commits into from
Aug 26, 2024

Conversation

volkm
Copy link
Contributor

@volkm volkm commented Aug 23, 2024 •
edited
Loading

  • Use C++20 and fixed some includes (resolves Support for C++20 #286)
  • Bump CMake to 3.22
  • Removed support for Debian 11 and Ubuntu 20.04
  • Regularly enable CLN and Ginac again for Apple Silicon

@sjunges
Copy link
Contributor

sjunges commented Aug 23, 2024

This is maybe more general than this PR, but should we indeed still rely on CLN and GiNaC where possible?

@volkm
Copy link
Contributor Author

volkm commented Aug 23, 2024

Do we have an idea of the performance difference when using CLN or GMP?

@volkm
Copy link
Contributor Author

volkm commented Aug 23, 2024

For the files ExplicitQualitativeCheckResult.cpp and ExplicitQuantitativeCheckResult.cpp I moved the include RationalNumberAdapter.h before the usual header file in order for the compilation to be successful. I have no idea why the include order is relevant here. Feel free to suggest a better fix.

@volkm volkm marked this pull request as ready for review August 23, 2024 17:04
@sjunges
Copy link
Contributor

sjunges commented Aug 26, 2024

Left some minor comments, otherwise, LGTM, thanks for your work on this

@volkm volkm merged commit 79908cc into moves-rwth:master Aug 26, 2024
13 checks passed
@volkm volkm deleted the future branch August 26, 2024 11:49
@volkm volkm mentioned this pull request Nov 15, 2024
Merged
@volkm volkm mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjunges sjunges sjunges left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for C++20
2 participants
@volkm @sjunges