Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix policy iteration for minimal reach reward properties #554

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

sjunges
Copy link
Contributor

@sjunges sjunges commented May 24, 2024

This PR tracks bughunting for a bug

Fixes the initial policy computation. The previous implementation did not correctly handle choices to states with infinite reward.

@tquatmann tquatmann changed the title add assertions in a bug hunt Fix policy iteration for minimal reach reward properties May 29, 2024
@tquatmann
Copy link
Member

I hijacked this PR to push a fix to #555 (I wanted to keep the assertions introduced by @sjunges ).

@sjunges
Copy link
Contributor Author

sjunges commented Jun 1, 2024

Great

@sjunges sjunges merged commit b997186 into moves-rwth:master Jun 1, 2024
15 checks passed
@sjunges sjunges deleted the policyiteration-bughunt branch June 1, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants