Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove an instance of boost::any #453

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sjunges
Copy link
Contributor

@sjunges sjunges commented Dec 3, 2023

No description provided.

@sjunges
Copy link
Contributor Author

sjunges commented Dec 3, 2023

There was a problem with the ci and downloading boost.., but i cannot restart the CI @volkm

@volkm
Copy link
Contributor

volkm commented Dec 4, 2023

I can rerun the jobs for some reason. Let's see whether it works the second time.

Copy link
Contributor

@volkm volkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjunges
Copy link
Contributor Author

sjunges commented Dec 4, 2023

I do not understand even remotely what happens here :/

@sjunges
Copy link
Contributor Author

sjunges commented Dec 4, 2023

This line error: incomplete type 'std::is_copy_constructible<boost::optional<std::any> >' used in nested name specifier makes me think that boost::optional and std::any may not be compatible and that one has to use std::optional here.

@tquatmann
Copy link
Member

Given that this happens in Ubuntu 20.04, this could be a bug with, e.g., older boost versions.

Given that std::any can be uninitialised, the type boost::optional<std::any> does not make a lot of sense in the first place. We could simplify this to just std::any and use the has_value function.

@sjunges
Copy link
Contributor Author

sjunges commented Dec 6, 2023

Agreed, thanks for the suggestion.

@sjunges sjunges marked this pull request as draft December 11, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants