separate collision_object creation from publishing #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * \param pose - location of center of block | ||
| * \param name - semantic name of MoveIt collision object | ||
| * \param size - height=width=depth=size | ||
| * \param color to display the collision object with | ||
| * \return true on sucess | ||
| **/ | ||
| moveit_msgs::CollisionObject createCollisionBlock(const geometry_msgs::Pose& block_pose, const std::string& name, | ||
| double block_size); |
There was a problem hiding this comment.
is it possible for the CollisionObject msgs type to support color as well?
There was a problem hiding this comment.
we would have to change the msg
| @@ -323,33 +323,40 @@ class MoveItVisualTools : public rviz_visual_tools::RvizVisualTools | |||
| const rviz_visual_tools::colors& color = rviz_visual_tools::GREEN); | |||
|
|
|||
| /** | |||
| * \brief Create a MoveIt Collision block at the given pose | |||
| * \brief Create/Publish a MoveIt Collision block at the given pose | |||
| * \param pose - location of center of block | |||
| * \param name - semantic name of MoveIt collision object | |||
| * \param size - height=width=depth=size | |||
| @@ -323,33 +323,40 @@ class MoveItVisualTools : public rviz_visual_tools::RvizVisualTools | |||
| const rviz_visual_tools::colors& color = rviz_visual_tools::GREEN); | |||
|
|
|||
| /** | |||
| * \brief Create a MoveIt Collision block at the given pose | |||
| * \brief Create/Publish a MoveIt Collision block at the given pose | |||
There was a problem hiding this comment.
i'd rather you copy this doxygen for reach function. it seems these two functions due fairly different things, and the \brief should explain that difference better.
| @@ -323,33 +323,40 @@ class MoveItVisualTools : public rviz_visual_tools::RvizVisualTools | |||
| const rviz_visual_tools::colors& color = rviz_visual_tools::GREEN); | |||
|
|
|||
| /** | |||
| * \brief Create a MoveIt Collision block at the given pose | |||
| * \brief Create/Publish a MoveIt Collision block at the given pose | |||
| * \param pose - location of center of block | |||
| * \param point1 - top left of rectangle | ||
| * \param point2 - bottom right of rectangle | ||
| * \param name - semantic name of MoveIt collision object | ||
| * \param color to display the collision object with | ||
| * \return true on sucess | ||
| **/ | ||
| moveit_msgs::CollisionObject createCollisionObject(const Eigen::Vector3d& point1, const Eigen::Vector3d& point2, |
There was a problem hiding this comment.
this should be createCollisionCuboid right? Even better: createCollisionCuboidMsg
| @@ -358,6 +365,10 @@ class MoveItVisualTools : public rviz_visual_tools::RvizVisualTools | |||
| * \param color to display the collision object with | |||
| * \return true on sucess | |||
| **/ | |||
| moveit_msgs::CollisionObject createCollisionObject(const Eigen::Isometry3d& pose, double width, double depth, | |||
There was a problem hiding this comment.
same comments:
rename function to include Cuboid
src/moveit_visual_tools.cpp
Outdated
| double depth, double height, | ||
| const std::string& name) | ||
| { | ||
| geometry_msgs::Pose pose_msg = tf2::toMsg(pose); |
There was a problem hiding this comment.
typically in *_visual_tools, we use the built-in converter helper function rather than tf2, could you use that? e.g. convertPose()
same below
mlautman
force-pushed
the
create-and-pub-separately
branch
2 times, most recently
from
e626338 to
6c354a5
Compare
mlautman
force-pushed
the
create-and-pub-separately
branch
from
6c354a5 to
b274866
Compare
|
@davetcoleman Done |
|
Ive just retriggered travis, but i think you need to rebase on master with the travis fix you just made? |
davetcoleman
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git seems to have messed up the diff. Any suggestions to avoid this?