Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of commented out lines of code #646

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AdamPettinger
Copy link
Contributor

Description

The Move Group C++ Interface tutorial for Noetic has some of the move/execute lines commented out:

  • // move_group_interface.execute(my_plan);
  • // move_group_interface.move();

which makes the tutorial formatting add these as plain text and makes the page look weird:
image

This PR changes those lines so they appear as code that is commented out.

It also comments out an execute call later in the tutorial that gives a "no controllers found" warning if left in

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@AdamPettinger AdamPettinger force-pushed the mvi-fix-commented-formatting branch from f62c5a8 to 38c2509 Compare June 9, 2021 16:27
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should the robot not move? In simulation that shouldn't be a problem.

@AdamPettinger AdamPettinger force-pushed the mvi-fix-commented-formatting branch from 38c2509 to 58d4ed7 Compare June 9, 2021 22:01
@AdamPettinger
Copy link
Contributor Author

AdamPettinger commented Jun 9, 2021

Why should the robot not move? In simulation that shouldn't be a problem.

Good question... The short answer: because that is how it was before this PR. The longer answer: this tutorial wasn't always planning starting from the end of the previous plan, so some of the plans being executed was causing problems with the starting state and the robot state not being the same.

I reworked the flow of the tutorial a bit to show the execute() and move() methods, and have the sim panda move through some of the plans.

@AndyZe AndyZe changed the title Fix formmatting of commented out lines of code Fix formatting of commented out lines of code Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants