Add note about uninstalling debians before installing MoveIt2 from source #763
Conversation
|
Wouldn't it be better if you fix MoveIt2's build config? Obviously, the include order is screwed. |
|
@rhaschke the include order might be screwed but that's another, separate issue. The problem here (as I understand it) is colcon doesn't support overlays and underlays. @tylerjw prob knows more. Here are some links where we've had to suggest debian removal or users figured it out on their own. I know there are more occurrences but these are the ones I can find easily: moveit/moveit2#826 (comment) |
|
@rhaschke here is some threads about it: colcon/colcon-core#465 The short story is that overlays do not work in ROS 2. |
I'm sorry, but this statement is wrong. workspace overlays are a fundamental building block of ROS and they work both in ROS1 and ROS2. Yes, there was a bug related to include-folder ordering in Galactic and before (see ament/ament_cmake#402). The override warning introduced in colcon/colcon-core#449 as an error and later downgraded to a warning (colcon/colcon-core#466) pops up any time you attempt to override a package. So, yes, if you want to avoid the warning completely, you need to uninstall debian packages. But they don't break the build if you follow best-practice rules. |
Do you know of any documentation on how to fix this? I'd be happy to clean this up if I can. My understanding (probably mis-understanding) from reading those threads is that all they did was add a warning because they decided they couldn't fix it. |
|
Did you read this doc linked from one of the comments? |
This makes me so frustrated. I've asked people from OR several times if there are docs for this somewhere. Why did they hide these docs here if everyone who publishes a library needs to know about this? Shouldn't this be in the docs for ament in the main ROS docs? This smells so much like something technical is broken about the tooling (cmake, ament, colcon) and they decided to "solve" it by requiring users to do yet more things they will easily make mistakes doing. Anyway, I'll go try to make this update to MoveIt2 and all the libraries I publish. |
|
Merging since it's useful information, for now. We can revert it later if MoveIt installation gets cleaned up. |
This simple change should prevent some issues like this one: moveit/moveit2_tutorials#546