convert both list and dict columns to json #1294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
shaunagm
reviewed
Feb 14, 2025
| @@ -794,7 +794,7 @@ def copy( | |||
| quote: Optional[str] = None, | |||
| schema: Optional[List[dict]] = None, | |||
| max_timeout: int = 21600, | |||
| convert_dict_columns_to_json: bool = True, | |||
There was a problem hiding this comment.
This is a breaking change because it renames a parameter. I don't know that it will impact many people because the parameter was only added four months ago - it might be that you're the only one using it - and if we are going to play fast and loose with the API I guess now's the time to do it. But alternatively you could just add a second parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1143, an update was made that enabled the BigQuery connector to automatically load dict columns as JSON strings rather than fail to load and error out.
List columns need the same fix - they cannot load by default into BigQuery and need to be converted to a JSON string. This PR makes that update.