Use a temporary docker postgres container for postgres DB sync tests #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinweisgrau
force-pushed
the
postgres
branch
from
ed16c0b to
7197a5c
Compare
Previously, the env var PGPORT would be overridden by the default value 5432. This still works as long as PGPORT isn't set.
prior implementation would not work if a postgres table was defined with a schema, as the quoting of `"schema.table"` is not valid and it needs to be `schema."table"`
this runs the test in a throwaway postgres docker container rather than needing to run the tests on an actual persistent postgres server
austinweisgrau
force-pushed
the
postgres
branch
from
7197a5c to
db794e8
Compare
expects an integer, but in this case it's actually gonna be a string, and that's OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should follow #1242
Uses the testcontainers package to easily generate and use a temporary postgres docker container for tests. Allows for running tests on postgres without running a persistent server separately, which should enable us to run tests on postgres in the CICD environment.