Add duckdb_id to logging + upgrade to 1.1.3 #60
+231
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to tie client connector logs from Fivetran to the backend logs.
duckdb_idis more useful thanconnection_idbecause some queries are purely local, so Describe endpoint will often not itself leave a trace on the server. But the initial connection establishment will haveduckdb_id. And since there is always only one connection per database instance, no information is lost.I also upgraded DuckDB version to 1.1.3 to get access to
md_current_client_duckdb_id()scalar function (I missed that I never upgraded since 1.0.0).