GL: new "apple-crashy-msaa-default-framebuffer" workaround #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an increasing number of projects that use ANGLE or Zink on that platform, and this workaround makes no sense there.
First spotted in July 2024 with magnum-player, and back then the only reliable solution was to disable MSAA altogether. Fortunately this fixes it as well, unfortunately there's no way to know if the default framebuffer is actually multisampled, so it's done always. Co-authored-by: Vladimír Vondruš <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion from @DavidPeicho turned into a builtin workaround.
Unfortunately I apparently reduced it way too much so it doesn't actually fix the issue anymore, likely because originally it was done together with a dummy draw and now it isn't, so that needs to be investigated and fixed first. Maybe just a framebuffer clear could help? I hope I don't need to create a dummy shader and all that as well...