[INJIMOB-2985] make authorization_servers optional and add fallback logic #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhip2565
force-pushed
the
injimob-2985
branch
from
3ba52c1 to
e1b6137
Compare
swatigoel
approved these changes
Feb 27, 2025
KiruthikaJeyashankar
suggested changes
Feb 27, 2025
abhip2565
force-pushed
the
injimob-2985
branch
from
e1b6137 to
6f337f1
Compare
KiruthikaJeyashankar
suggested changes
Feb 28, 2025
KiruthikaJeyashankar
approved these changes
Mar 4, 2025
swatigoel
requested changes
Mar 4, 2025
machines/Issuers/IssuersService.ts
Outdated
| await CACHED_API.fetchIssuerAuthorizationServerMetadata(server); | ||
|
|
||
| if ( | ||
| (authorizationServersMetadata?.['grant_types_supported'] || ["authorization_code", "implicit"]).some(grant => |
There was a problem hiding this comment.
extract ["authorization_code", "implicit"] as constant outside for loop.
It looks complex to understand if condition. If we name it defaultGrantTypeSupported, it will be more readable.
machines/Issuers/IssuersService.ts
Outdated
| return authorizationServerMetadata['authorization_endpoint']; | ||
|
|
||
| throw new Error( | ||
| OIDCErrors.AUTHORIZATION_ENDPOINT_DISCOVERY.GRANT_TYPE_NOT_SUPPORTED, |
There was a problem hiding this comment.
I feel, instead of giving GRANT_TYPE_NOT_SUPPORTED we should have generic error like failed to fetch data.
Definite error should be used if we will get that error only.
…ogic Signed-off-by: Abhishek Paul <[email protected]>
…tadata Signed-off-by: Abhishek Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue ticket number and link