-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Critical code review PR - Last sprint handover checklist of 0.11.0 release #295
Draft
vishwa-vyom
wants to merge
436
commits into
master
Choose a base branch
from
release-0.11.x
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[DSD-6753]removed mimoto and esignet dependencies
Signed-off-by: srikanth716 <[email protected]>
Signed-off-by: srikanth716 <[email protected]>
Signed-off-by: srikanth716 <[email protected]>
…anslation Injiver 829 error message translation
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
…njiver-794-online-sharing-car-portal Signed-off-by: srikanth716 <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Injiver 587 ovp endpoints
Signed-off-by: srikanth716 <[email protected]>
…into injiver-794-online-sharing-car-portal Signed-off-by: srikanth716 <[email protected]>
…ar-portal Injiver 794 online sharing ovp and custome theme
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
[INJIVER-846] refactor remove unwanted logs
Signed-off-by: srikanth716 <[email protected]>
Signed-off-by: srikanth716 <[email protected]>
Signed-off-by: srikanth716 <[email protected]>
Signed-off-by: srikanth716 <[email protected]>
…x test cases and remove unwanted logs Signed-off-by: srikanth716 <[email protected]>
Signed-off-by: srikanth716 <[email protected]>
Signed-off-by: srikanth716 <[email protected]>
Signed-off-by: srikanth716 <[email protected]>
Signed-off-by: srikanth716 <[email protected]>
[INJIVER-846] refactor request time out
…able Signed-off-by: srikanth716 <[email protected]>
[INJIVER-846] refactor vp request status and default timeout env variable
Signed-off-by: srikanth716 <[email protected]>
Merge remote-tracking branch 'upstream/master' into release-0.11.x
[INJIVER-846] refactor client Id validationa
* [INJIVER846] removed unused method Signed-off-by: srikanth716 <[email protected]> * [INJIVER846] refactor cliend Id validation Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor config json Signed-off-by: srikanth716 <[email protected]> --------- Signed-off-by: srikanth716 <[email protected]>
* [INJIVER846] removed unused method Signed-off-by: srikanth716 <[email protected]> * [INJIVER846] refactor cliend Id validation Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor config json Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> --------- Signed-off-by: srikanth716 <[email protected]>
* [INJIVER846] removed unused method Signed-off-by: srikanth716 <[email protected]> * [INJIVER846] refactor cliend Id validation Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor config json Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> --------- Signed-off-by: srikanth716 <[email protected]>
* [INJIVER846] removed unused method Signed-off-by: srikanth716 <[email protected]> * [INJIVER846] refactor cliend Id validation Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor config json Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> --------- Signed-off-by: srikanth716 <[email protected]>
…e permission for deployment script. Signed-off-by: techno-467 <[email protected]>
[MOSIP-39930] updated the deployment script and changed the executabl…
* [INJIVER846] removed unused method Signed-off-by: srikanth716 <[email protected]> * [INJIVER846] refactor cliend Id validation Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor config json Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * [INJIVER-846] refactor configmaps on deployment Signed-off-by: srikanth716 <[email protected]> * refactor rerendering order and default order Signed-off-by: srikanth716 <[email protected]> * [INJIVER-1024] version upgrade to verify mock vc Signed-off-by: srikanth716 <[email protected]> --------- Signed-off-by: srikanth716 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created just to add the review comments as part of the critical code review task of last sprint handover checklist for release of 0.11.0 version.
** THIS PR SHOULD NOT BE MERGED **