chore(release): v0.4.1 — publish the resolver fix - #16
Merged
Conversation
Ships the resolver fix from #15, which has been on main since it merged but was never published: the version stayed at 0.4.0, so `npm i @moshcoder/moshpit-dns` still gives you a bridge that answers `ANSWER: 0` for names that resolve perfectly well. That authoritative-empty answer is the worst shape available — a client treats it as final, `dig` reports the name exists, and nothing logs an error. The bug is invisible from the outside, which is why it survived a release. Same pattern as #14: a fix sitting behind a stale version is not shipped, it is just merged.
ThreatCrush Security Scan0 finding(s) No findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the version so #15 actually reaches anyone.
#15 merged yesterday and
npm i @moshcoder/moshpit-dnsstill installs 0.4.0 — the build whose resolver answersANSWER: 0for names that resolve fine. Merging fixed the repo; it did not fix the thing people install.The failure it removes is the quiet one: an authoritative-empty answer is treated as final by the client,
digreports the name exists, and nothing anywhere logs an error. A user experiences it as "Moshpit is broken" with no thread to pull.This is the same shape as #14, whose own body says the
recordscommand "has been on main since #12 merged but was never published." Third time; worth automating eventually.npm pack --dry-runconfirmslib/dns.mjs(30.0kB) carriesaddressAnswer/buildChainResponse— verified rather than assumed, since a shipped artifact missing the fix is precisely the bug being fixedAfter merge: tag
v0.4.1andnpm publish.🤖 Generated with Claude Code