feat(moshscript): complete moshscript implementation (PRD 0004) - #18
Merged
Conversation
…#16) - Add bin/moshscript.mjs shebang-ready executable (R14) - Add 'moshscript' to package.json bin map (R14) - Update install.sh to create/remove moshscript wrapper (R14) - Update help() with full vocabulary + JS-legal docs (R10) - Update TUI /help with moshscript vocab + shebang info (R10) - Rewrite README moshscript section: commands, dry-run, shebang, ask/notify (R10) - Add 17 unit tests for verb→argv dry-run mapping (R12) - Update PRD 0004 status to Accepted
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the moshscript implementation per PRD 0004.
Closes #16
Changes
bin/moshscript.mjsmoshcode run. Enables#!/usr/bin/env moshscriptin.moshfilespackage.json"moshscript"to thebinmap sonpm link/npm install -gwires it onto PATHinstall.shmoshscriptshell wrapper alongsidemoshcodeduring install; cleans it up on removebin/moshcode.mjshelp()to show the full vocabulary (local + CLI verbs), document JS-legality, shebang support,--dry-run, andask()/notify()src/tui.mjs/helpto show the full moshscript vocabulary, JS-legal note, and shebang lineREADME.mdtest/cli.test.mjsrunScript()prd/0004-...mdDrafttoAcceptedPRD requirement coverage
--max, CLI shell-out,--dry-run, error handling, extensible registrymoshcode commands,help, TUI/help, and README all reflect the full JS-legal vocabularyalive.moshruns unchangedawait,argv,envall workmoshscriptexecutable,package.jsonbin map,install.shwrappernotify()+ask()with approval pollingrun()composes scriptsTests
99 pass / 2 fail (pre-existing macOS
/private/varsymlink issue in tool passthrough tests, unrelated to moshscript)