fix(tui): stop styling the agent-view notice as an error - #134
Merged
Conversation
`/agents <engine>` printed its notice through err(), so opening an engine's agent view rendered a red ✗ for what is purely informational — it reads as a failure when nothing failed. Split the two cases the message already covered: an agentsView engine is just opening a listing (info), while everything else really does bypass the engine's native approval prompts (new warn helper, amber ⚠). bin/moshcode.mjs printed ⚠ for both branches; it now matches. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
ralyodio
marked this pull request as ready for review
July 31, 2026 07:38
Merged
ralyodio
added a commit
that referenced
this pull request
Jul 31, 2026
Cuts a release off main so the fixes merged after v0.13.1 actually reach installs. v0.13.1 shipped before #135, so re-running the installer still handed you a moshcode that reported turso as missing. Included since v0.13.1: - #135 fix(tools): find turso in ~/.turso instead of reporting it missing - #134 fix(tui): stop styling the agent-view notice as an error - #133 fix(runtime): deliver fire-and-forget notify() when the script throws Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
/agents <engine>printed its notice througherr(), which renders a red✗. Opening an engine's agent view therefore looked like a failure when nothing had failed —privacycode agent listexits 0.Observed:
Why
The message already branched on
engine.agentsView, but both branches shared the error styling. Those two cases aren't the same severity:Changes
src/ui.mjs— add anambercolor and awarnhelper (⚠), sitting betweeninfoanderr.src/tui.mjs— agent-view case usesinfo, bypass case useswarn.bin/moshcode.mjs— printed⚠for both branches; now matches the same split.Testing
node --test test/engines.test.mjs— 18/18 pass. The existing/agent mode:/stderr assertion (test/engines.test.mjs:108) still matches, since only the prefix changed.🤖 Generated with Claude Code