Clang upd #13
Open
Clang upd #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move getGlobalPlacement() and fix alignment direction for transformed objects
…derSketch::addSelection2()
Signed-off-by: CalligaroV <[email protected]>
Problem with the same cause as FreeCAD#16212.
The actual optimal size of the window depends on many details, like UI style, system fonts, OS etc ... so lets auto-resize the window to fit the content before display.
The image is already set in the UI file, it is not necessary to set it again
As shown in the image here: FreeCAD#16485 (comment)
* Sketcher: initialize geometry history limit variable The variable seems to be uninitialized, valgrind complais about it. The `git grep geoHistoryLevel` and the code ispection suggest it is never set. If initialized to zero, most of the related code is never used, which can point to the fact there is either another bug or the code is unused. The variable was introduced in 42bf92a. * Sketcher: Default geoHistoryLevel to 1 --------- Co-authored-by: Chris Hennes <[email protected]>
…y. (FreeCAD#16416) * Limit anti alias samples for better compatibility. might solve Wayland problem, issue FreeCAD#15665 * Antialias samples are taken from display prefs * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ocking Fem: Enable cancel meshing for Gmsh - fixes FreeCAD#5914
Fem: New implementation of FemMesh Netgen object
…ViewProviderSketch-addSelection2-call-convertSubName Sketcher/Toponaming: call SketchObject::convertSubName() in Gui selections
* MeasureGui: Revert temporary measure object creation Reverts the temporary creation of measurement objects that was added in FreeCAD#15122 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * MeasureGui: Adress review comments - Remove _mDocument and _mGuiDocument - Replace c-style casts with dynamic_cast - Add file guard - Remove leftover canAnnotate method * MeasureGui: Fix crash when selecting elements from different documents * MeasureGui: Add additional type check in ensureGroup * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… is open A group command is not disabled if its default command is disabled. This allows it to invoke the command when it should be impossible. To fix the problem override the isActive() method in the sub-classes CmdPartDesignCompDatums & CmdPartDesignCompSketches This fixes FreeCAD#16294
for more information, see https://pre-commit.ci
…7084) * Open recent documents from start same way as in menu * Make insert spreadsheet create document if not available. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Chris Hennes <[email protected]>
Store changes made in TextDocumentEditorView immediately to TextDocument. This fixes the issue reported in https://forum.freecad.org/viewtopic.php?p=786175#p786175
Multiple places in code, asserts for bad types would trigger SIGABRT. This is not just limited to FreeCAD#16316 with SoZoomTranslation, but multiple more places, not described in issue, but I experienced myself. Fixes FreeCAD#16316
* BIM: remove py2 compatibility code * remove unused six from conda environments
SketchObject::buildShape() used the geometries as they were created by the user. However, they are not accurate enough in order to create a closed wire. Instead the geometries after running the solver must be used because they are guaranteed to be accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.