Add rescaled classifier free guidance and offset noise #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
approved these changes
Oct 6, 2023
jazcollins
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Looks good to me!
If you wanted to make things even more concise, I left one suggestion to consolidate the boolean and float parameters for rescale guidance into a single Optional[float] parameter. The same could be done for the offset noise parameters - but what you wrote looks great and it is not necessary!
Landanjs
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two simple tricks that are claimed to improve image quality.
Trick 1: Rescaled classifier free guidance (see sec. 3.4 here)
Trick 2: Offset noise (see here)