Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple LoRA Finetuning (WIP) #164

Merged
merged 8 commits into from
Aug 21, 2024

Conversation

rishab-partha
Copy link
Contributor

@rishab-partha rishab-partha commented Aug 10, 2024

Added a bit of simple code for LoRA finetuning diffusion models -- need to test with FSDP but this is minimal and runs with toy matrices on one GPU at the moment.

Works at tests with FSDP now -- 10 eps of FT on dataset of 760 images takes ~10 min with performance shown below,
Sample image: Screenshot 2024-08-21 at 11 44 43 AM
Smoothed loss:
Screenshot 2024-08-21 at 11 46 16 AM
Memory trace:
Screenshot 2024-08-21 at 11 47 30 AM

@rishab-partha rishab-partha marked this pull request as ready for review August 21, 2024 18:43
Copy link
Collaborator

@coryMosaicML coryMosaicML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for doing this and testing it out!

@coryMosaicML coryMosaicML merged commit c63006e into mosaicml:main Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants