Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latent logger for T5-XXL text encoder #154

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

rishab-partha
Copy link
Contributor

@rishab-partha rishab-partha commented Jun 18, 2024

Adds functionality to precompute latents in the logger for compatibility with T5-XXL text encoder.

@rishab-partha rishab-partha changed the title Add latent logger + small fix to Image.Lanczos Add latent logger for T5-XXL text encoder Jun 18, 2024
Copy link
Collaborator

@coryMosaicML coryMosaicML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding this!

Copy link
Collaborator

@coryMosaicML coryMosaicML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost some comments before. A couple minor things.

diffusion/callbacks/log_diffusion_images.py Outdated Show resolved Hide resolved
diffusion/callbacks/log_diffusion_images.py Outdated Show resolved Hide resolved
diffusion/callbacks/log_diffusion_images.py Show resolved Hide resolved
diffusion/callbacks/log_diffusion_images.py Show resolved Hide resolved
diffusion/callbacks/log_diffusion_images.py Outdated Show resolved Hide resolved
@gupta-abhay gupta-abhay merged commit 52088bf into mosaicml:main Jul 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants