-
-
Notifications
You must be signed in to change notification settings - Fork 44
Color Positive Film #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dog-god-rus
wants to merge
18
commits into
mortuusars:1.20.1
Choose a base branch
from
dog-god-rus:1.20.1
base: 1.20.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Color Positive Film #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Positive film stuff
Increased saturation
The same thing as the dithering color converter but... different. Idk if this is even needed tbh
Add color positive
Positive film
Add IDs for positive film
Positive film
Positive film
Creative mode entries for color positive film
I just realized how pull requests work. Guess we ain' doin this fancy description thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a film photographer myself, I was kinda disappointed to see a lack of slide film (like Velvia) in the mod, so I decided to take it upon myself to implement it (and a couple other things, watch out for pull requests in the coming days). I don't know much about mod development, so it was a lot of trial-and-error to get this whole thing to work and compile, but the result is work-able. As a draft, I've implemented this stuff for Forge 1.20.1, though in theory it should be extendable to other versions and mod loaders, since there's nothing here that requires forge. It's just the one I found the most documentation on lol
Anyways, here's what this pull request implements:
Color Positive Film
Crafted with three gunpowder, two kelp, an emerald, and the three color dyes needed for the reversal process. It's a bit on the expensive side, yes, but so it is IRL.

Textures
I've made some programmer art for the color positive film and developed color positive film, which admittedly aren't the best (just recolors of the existing stuff to match how it looks IRL, plus fuji green for the film reel for obvious reasons), but again, should do as a draft.

Development
Color positive film can be shot just like any other, but to develop it, it is yet again, more expensive: the process now requires a potion of night vision, because why not. It's simple-ish to make and fits with the theme of a more complex chemical process. (I totally didn't pick it because it was the first potion in line after the awkward ones in the creative menu, what are you talking about)

Image Viewing
When viewed in the Lightroom, color positive film will have a black border with positive images (wow). The images will also have increased saturation, because Velvia is cool.

Printing
Printing the positives still takes the normal CMYK color dyes, but runs at the speed of black-and-white printing. Technically this isn't very realistic but ya gotta give the player at least some leeway after the kick in the teeth that were those crafting recipes. Maybe we could spin this as, like, peel-apart printing or something. Idk.

Anyways, when printed, images will still remain a positive, and will obviously keep their vibrant colors, as they should.
(minor spoiler on another thing I got working)
Translations
Feels like a bit of a stretch to put this here, but, uh, I also translated it to Russian because that's one of the languages I can speak. Incredible stuff.
Closing remarks
And that's basically everything! Whilst this, as it is, really isn't ready for prod, if someone can get it running for fabric or the other game versions (for me, it literally doesn't compile unless I cut out all the sections of code related to fabric or other mod integrations from the gradle files, not sure why), I think it could be a really nice update to the mod.
In the meanwhile, if anyone wants to test it, I've uploaded a build on my branch's releases. It's for forge 1.20.1, obviously, and should in theory work. I wrote most of this code a couple weeks back, but have only now decided to actually put it to use anywhere.