ci(lint): add typos spell checker and editorconfig#65
ci(lint): add typos spell checker and editorconfig#65
Conversation
- Add `typos.toml` with hex pattern exclusions and `crate-ci/typos` CI job - Add `.editorconfig` for consistent editor settings (UTF-8, LF, indent) - Add clippy check for feature-gated integration tests in lint workflow
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdded repository editor settings via Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/lint.yml:
- Around line 57-58: The CI step runs an invalid Clippy command referencing a
non-existent package feature and test target ("cargo clippy -p morph-node --test
it --features test-utils -- -D warnings"); either remove the invalid flags or
add the corresponding entries to Cargo.toml. Fix by editing the workflow to run
Clippy simply for the package (e.g., "cargo clippy -p morph-node -- -D
warnings") or, if you intended a feature/test, add a "test-utils" feature in
crates/node/Cargo.toml and a [[test]] named "it" in the crate so "--features
test-utils" and "--test it" are valid; ensure the symbols --test it, --features
test-utils, and -p morph-node are updated consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 91a39d2b-658d-40c5-82b3-f61425b45094
📒 Files selected for processing (3)
.editorconfig.github/workflows/lint.ymltypos.toml
morph-node does not have a test-utils feature, causing clippy CI to fail. Remove the feature-gated integration test clippy step.
Summary
typos.tomlwith hex pattern exclusions andcrate-ci/typosCI job for spell checking.editorconfigfor consistent editor settings (UTF-8, LF line endings, indent rules)morph-node --test it --features test-utils)Test plan
typospasses locally with zero findingstyposjob runs and passesSummary by CodeRabbit
Chores