Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ie leak #2351

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Ie leak #2351

wants to merge 4 commits into from

Commits on Apr 12, 2012

  1. Fix IE leaks caused by ._fireEvent circular reference

    changed empty, now it uses destroy to clean every children tree
    this change need a check on destroy, because childNodes returns
    textNodes
    on dispose i removed the _fireEvent reference breaking the circular
    reference and allowing the gc to clean up the memory (tested with
    sIEve-0.0.8)
    set('html',...) don't leak but set('text',...) does, so added a
    Element.Properties.text setter and done empty() before setting the text
    
    I setup a test page that creates 1000 divs, added these divs to the
    body and then use empty(), set('html', ...) and set('text', ...) to get
    rid of them, causing a 1000 element leak,
    with these changes I managed to drop the leaks from 1000 to 0.
    kentaromiura committed Apr 12, 2012
    Configuration menu
    Copy the full SHA
    4c68d39 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14f5deb View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2012

  1. Configuration menu
    Copy the full SHA
    86611be View commit details
    Browse the repository at this point in the history
  2. Applied the suggestions

    revert dispose, destroy now filter nodeType, so Element.properties.text
    can use empty without throwing errors, delete properties in clean.
    kentaromiura committed Apr 13, 2012
    Configuration menu
    Copy the full SHA
    f59f069 View commit details
    Browse the repository at this point in the history