Prevent invalid character ranges #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove tail recursion, fix var name typo.
gukoff
changed the title
|
@moodmosaic ping! |
moodmosaic
reviewed
Jul 24, 2024
Co-authored-by: Nikos Baxevanis <[email protected]>
|
@gukoff, thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--
Throwing exception from Xeger ctor is a somewhat controversial choice.
The original library seems to not do so, and we accept the other invalid constructions such as
\w{7,1}.At the same time, in the function
MakeIntervalthere's already a precedent of throwing.Alternatively, I thought of of adding examples of unsolvable regexes to the README, and in the error message link to this section of README. The only examples I can think of are
[\w-.]and\w{7,1}.--
Should solve #44