Added testcase that throws a StackOverflowException #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reporting this. In order to take proper action(s), I will have to do a comparison with the original libraries (dk.bris.automaton and xeger). AFAICT, this is also related to #5. |
|
Yeah I noticed. I thought a simpler pattern causing the same problem might be easier to figure out. (not sure) |
|
This requires a comparison with the original libraries (dk.bris.automaton and xeger) – which I can't really find such a big time-slot to perform (it requires to install a Java IDE and debug the code side-by-side) :$ Could you try a different or similar Regular Expression? |
|
As of Fare 1.0.1, the pattern provided in the Pull Request doesn't throw an exception. Are there any further actions to take into account? |
|
Closing this due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.