chore: repoint j2k pin from fork to upstream main (all fixes merged) - #78
Merged
Conversation
All three fixes the fork pin carried are now merged upstream: frames-sg/j2k#63 (region IDWT), frames-sg/j2k#65 (tile skip), and frames-sg/j2k#70 (deep region reduction, the maintainer's implementation of the API proposed in frames-sg/j2k#66). No crates.io release carries them yet — v0.8.0 predates the merges — so the [patch.crates-io] section stays, now pointing at upstream rev 85e7e29. Call-site changes: upstream kept the proposed public signature decode_region_scaled_pow2_into unchanged, but did not expose the fork's Rect::scaled_covering_denominator helper; jp2.rs now computes the covering rect locally. j2k version requirement bumped 0.7 -> 0.8. Validated: task ci green; spike2 differential goldens 6/6 (lossless bit-exact vs OpenJPEG, lossy within tolerance, HTJ2K bit-exact); codec_masters 9/9. Refs #21. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The dependency-review action fetches license data from api.deps.dev and OpenSSF Scorecard data from api.securityscorecards.dev; both were blocked by the egress allowlist, failing the job with a bare 'fetch failed' (observed in the harden-runner agent log as 'domain not allowed'). Allowlist derived from the audit run per issue #6 canon. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All three fixes our fork pin carried are now merged upstream — frames-sg/j2k#63 (region IDWT), frames-sg/j2k#65 (tile skip), and frames-sg/j2k#70, the maintainer's implementation of the deep-region API proposed in frames-sg/j2k#66. No crates.io release carries them yet (v0.8.0 predates every merge), so the
[patch.crates-io]section stays but now points at upstreammain(rev85e7e29) instead of our fork. The fork branches are superseded.Changes
Cargo.toml: pin repointedCarlAllenn/j2k→frames-sg/j2k, comment updated to the release-gate framing (see the amendment on Consume the three upstream j2k fixes; drop the temporary [patch.crates-io] #21)crates/core/Cargo.toml:j2k = "0.7"→"0.8"(upstream main is 0.8.0-based)deny.toml: allow-git entry follows the pinjp2.rs: upstream kept our proposeddecode_region_scaled_pow2_intosignature verbatim, but kept the covering-rect helper private; we now compute it locally (scaled_covering_pow2, same documented floor-origin/ceil-far-edge contract)Validation
task cigreentask spike2differential goldens 6/6: lossless bit-exact vs OpenJPEG, lossy mean |Δ| 0.02 / max 2, HTJ2K bit-exact, quarter-scale goldens exact, perf gate passescodec_masters9/9 including partial-grid exact pixels and the reduced-resolution ladder testUnpin gate (#21) is now solely the next upstream release.
🤖 Generated with Claude Code