-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time/space benchmarks #24
base: master
Are you sure you want to change the base?
Conversation
Is something that can be loaded into the inspector Profiles tab feasible? |
I was hoping to get programatic access to the retain paths but I can't find one, so perhaps I'll migrate this to webkit-devtools-agent. |
Perhaps CSV. This is all for naught without a way to visualize the graphs, and loading it up in a spreadsheet seems like a fast-path, and other tools wouldn’t mind CSV either generally. |
And it would probably be good to set some of this up for pass/fail so we can verify that we’ve stomped out the leakage. |
I think we’ll need to adapt this case to measure churn in addition to leakage to evaluate the removal of |
I'm looking at this and I think there are basically three things worth doing:
|
@asolove could you rebase on master. Thx. |
I started writing simple FRB benchmarks. This one seems to show that we're leaking an array. The memory leaked works out consistently to a not-coincidental ~32bytes per item in the input array.
What should sensible output from these be? Actual numbers, or perhaps a limit on space/time and then each test either passes or fails?
Here's the current, very verbose, output: